Skip to content

Add GitHub Pages Action#1304

Merged
simpsoka merged 2 commits intogithub:mainfrom
peaceiris:patch-1
Dec 10, 2020
Merged

Add GitHub Pages Action#1304
simpsoka merged 2 commits intogithub:mainfrom
peaceiris:patch-1

Conversation

@peaceiris
Copy link
Contributor

@peaceiris peaceiris commented Nov 13, 2020

Pull-request for Issue #1303

Why:

Add the GitHub Pages Action which is listed at the Actions topic.

What's being changed:

N/A

Check off the following:

@welcome
Copy link

welcome bot commented Nov 13, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@peaceiris peaceiris mentioned this pull request Nov 13, 2020
Closed
@janiceilene
Copy link
Contributor

janiceilene commented Nov 17, 2020

@peaceiris Thanks so much for opening a PR! I'll get this triaged for review ⚡

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 17, 2020
@peaceiris peaceiris marked this pull request as ready for review November 20, 2020 04:45
@peaceiris
Add GitHub Pages Action
3a1ecd7 
Add the GitHub Pages Action which is listed at the Actions topic as same as softprops/action-gh-release

peaceiris/actions-gh-pages: https://github.com/peaceiris/actions-gh-pages - GitHub Actions for GitHub Pages: Deploy static files and publish your site easily. Static-Site-Generators-friendly.
Actions topic: https://github.com/topics/actions
@nitishgoukonde

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@peaceiris
Copy link
Contributor Author

peaceiris commented Dec 8, 2020

Updated!

@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@chiedo chiedo requested a review from simpsoka December 10, 2020 14:27
@chiedo
Copy link
Contributor

chiedo commented Dec 10, 2020

@simpsoka let us know what you think!

simpsoka
simpsoka approved these changes Dec 10, 2020
View reviewed changes
Copy link

@simpsoka simpsoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the add @peaceiris! :shipit:

@simpsoka
Copy link

simpsoka commented Dec 10, 2020

Am i this person? Lol

hahaha nope that's me :)

just had a chance to review and I love it! gonna get this merged in

@simpsoka simpsoka merged commit 03cd09f into github:main Dec 10, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

@peaceiris peaceiris deleted the patch-1 branch December 11, 2020 05:00
@snyk-bot snyk-bot mentioned this pull request May 23, 2021
Open
This was referenced Jul 14, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Aug 15, 2021
Open
Octomerger pushed a commit that referenced this pull request Dec 2, 2021
Massive DIFF_FILES crashes bash in repo-sync (#23326)
2601464 
* Massive DIFF_FILES crashes bash in repo-sync

Part of #1304

* gst

* make exception
jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@charislam @Loquacity
[UDA] Note that action signature is mandatory (github#1304)
fa169cc 
You must include an action signature for your job, even if you don't need to use the `job_id` and `config` arguments.

Also removed some repetition that is hard to maintain. (The UDA examples have already been moved into how-to guides.) Left the UDA page in concepts for now, but these will also be migrated over time.

Also some drive-by formatting changes to test the automated formatting set-up.

Co-authored-by: Lana Brindley <github@lanabrindley.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@simpsoka simpsoka simpsoka approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@peaceiris @janiceilene @nitishgoukonde @chiedo @simpsoka

Comments